search

cardoso / ReduxMovieDB

🎥 See the upcoming movies! ReSwift + RxSwift 💖 Hacktoberfest 🎃
MIT License
203 stars 35 forks source link

Remove disclosureIndicator in MovieListTableViewCell #40

Closed johnsabino closed 4 years ago

johnsabino commented 4 years ago

To resolve this bug, was necessary to remove the disclosure indicator of accessory view in MovieListTableViewCell.

johnsabino commented 4 years ago

OBS: The left space in landscape exists because of safe area of Iphones X and 11.

codecov-io commented 4 years ago

Codecov Report

Merging #40 into master will decrease coverage by 0.2%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #40      +/-   ##
=======================================
- Coverage    70.2%   70%   -0.21%     
=======================================
  Files          13    13              
  Lines         443   440       -3     
=======================================
- Hits          311   308       -3     
  Misses        132   132
Impacted Files Coverage Δ
...xMovieDB/Controllers/MovieListViewController.swift 89.24% <ø> (-0.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f57d4cb...0cea76b. Read the comment docs.

cardoso commented 4 years ago

@jonhpol thanks for your contribution, however I'm closing this and marking as invalid because it's a duplicate of https://github.com/cardoso/ReduxMovieDB/pull/39 and the solution shouldn't be removing the disclosure indicator, because I think it's important to have it.