search

cardstack / cardboard

Card Board - a Cardstack application for building narrative experiences
https://staging-cardboard.stack.cards/
8 stars 4 forks source link

Make ECR endpoint into an env variable #103

Closed jenweber closed 5 years ago

jenweber commented 5 years ago

I added ECR_ENDPOINT as an environment variable in Travis, with a value of 680542703984.dkr.ecr.us-east-1.amazonaws.com/cardboard, which was previously hard-coded in the deploy scripts.

The real purpose of this PR is to see if the same changes I made to project-template would be valid, if it was deployed: https://github.com/cardstack/project-template/pull/32

I'm not sure how else to review this besides trying it. It should have a look from someone who knows Docker well.

jenweber commented 5 years ago

Closed, see cardstack/project-template#32 which includes these changes, along with some fixes.