search

careerbuilder / ruby-cb-api

Ruby wrapper around the CareerBuilder.com APIs
Apache License 2.0
14 stars 18 forks source link

Better Error Message For Missing Response Field #251

Closed MajinFro closed 8 years ago

MajinFro commented 8 years ago

from consumer tech debt card... Ruby-cb-api: make error for "missing response field" better.

Example: https://rpm.newrelic.com/accounts/780558/applications/4991347/traced_errors/f2acfc-6ffc59d7-d8a1-11e5-9062-f8bc12425498?original_error_id=8760ae-b2f65b82-d8a1-11e5-9062-f8bc12425498

It just reads "Results" as the error message. When you look at the stack trace you can see it's a required field that's missing.

https://github.com/careerbuilder/ruby-cb-api/blob/master/lib/cb/responses/api_response.rb#L52

It would be really nice if it would give info about what API was called and what we were looking for. But at least say something more than just the name of the field.

Casao commented 8 years ago

Code Climate is bust again :(

MajinFro commented 8 years ago

closing because i goofed this up by not working on updated code. going to get everything fixed and then reopen.