search

careerbuilder / ruby-cb-api

Ruby wrapper around the CareerBuilder.com APIs
Apache License 2.0
14 stars 18 forks source link

Refactor validator specs #257

Closed Casao closed 8 years ago

Casao commented 8 years ago

Refactors a gnarly spec with a lot of in-test setup (and multiple descriptions that outright lie).

tkling commented 8 years ago

How would you feel about the 2 liners not having a newline between the let and it? It's a personal thing, but for me readability is funky when they're split up like this. Feels like 2 sentences in a single paragraph randomly separated by a blank line.

Casao commented 8 years ago

@tkling against it - i think there should always be a new line between setup and the actual specs for readability.

tkling commented 8 years ago

@Casao I feel ya, that's cool. I will cry to myself about it, carry on 😿 😿 😿

tkling commented 8 years ago

@Casao You should try out the no newline approach to 2 line tests. This could be you! https://www.youtube.com/watch?v=Aw_MqUxDlik

oochelz commented 8 years ago

It's as if this test suite got a makeover. It needs its own reality TV show to make people cry over the emotional transformation.

tkling commented 8 years ago

@oochelz I'M STILL CRYING ABOUT THE 2 LINERS WE CAN CRY TOGETHER THAT'D BE GREAT

oochelz commented 8 years ago

Hahahahahhaha, @tkling I like the separation of setup and expectations myself :P

tkling commented 8 years ago

@oochelz I would prefer this whole thing on one line if possible, gives us a reason to get 4K wraparound monitors :metal: