search

carekit-apple / CareKit

CareKit is an open source software framework for creating apps that help people better understand and manage their health.
https://www.researchandcare.org
Other
2.4k stars 445 forks source link

OCKBarChart does not render correctly with more than 6 days #266

Closed boscoybarra closed 4 years ago

boscoybarra commented 5 years ago

With more than 6 days of information OCKBarChart does not render correctly the bar chart, information is superimposed. Data loads incorrectly like the images attached. The issue occurs both in HTML and PDF formats.

In my opinion, it needs padding between bars, dates, and labels when loading more than 6 days because information superimposes on top of each other. The more days the worst. Please find the results attached as images.

The way to reproduce this is to complete Assessments or CarePlan data and see how the chart superimpose information when you add bar information with more than 6 days. You will have to change the date on your device and time travel to the future while completing assessments or activities day by day until you reach more than 6 days. I'm using an iPhone 5SE with iOS 11.4.1.

Thank you

data superimpose with ockbarchart

other example

erik-apple commented 4 years ago

We're going to close this issue now that CareKit 2.0 has been released. We are no longer providing bug fixes for version 1.2.

boscoybarra commented 4 years ago

We're going to close this issue now that CareKit 2.0 has been released. We are no longer providing bug fixes for version 1.2.

@erik-apple , thank you. Is this issue fixed on CareKit 2.0 ? Thank you!

erik-apple commented 4 years ago

Yep, the new bar charts support much denser data. You should still be careful not to overwhelm your users with data though!

Bar Chart Test

fedetop01 commented 1 year ago

Hi @erik-apple, I'm using the latest version of carekit, and I was trying to achieve the same thing you did here, displaying chart over an entire month. However, I'm struggling to accomplish the retrieve the data for an entire month, whereas the monthly view of the graph I did it extending the class that before displayed only the weekly chart. Could you help me understand how you set up such a monthly view, and especially how you retrieved the data?

gavirawson-apple commented 1 year ago

@fedetop01 Check out the conversation here, there are some helpful tips for setting up a monthly calendar.