Warning when uploading App

carekit-apple / CareKit

CareKit is an open source software framework for creating apps that help people better understand and manage their health.

https://www.researchandcare.org

Other

2.4k stars 443 forks source link

Warning when uploading App #672

Open macintosh-HD opened 1 year ago

macintosh-HD commented 1 year ago

Hi,

recently I get warnings when uploading my App to AppStore Connect. The logs say:

The app references non-public selectors in Payload/APPNAME.app/APPNAME: dismissViewController

I don't have a function with that name in my app. Upon further investigation I found that CareKit implements such function in the OCKContactViewController and it is private.

I only got the warning after switching to Xcode 14. Is it possible to make that function public to resolve the warning?

gavirawson-apple commented 1 year ago

Hi @macintosh-HD ! I'll do some investigating here - which branch of CareKit are you using?

macintosh-HD commented 1 year ago

Hi @gavirawson-apple, sorry for the late response. We are using the main branch.

gavirawson-apple commented 1 year ago

Thanks! I'll do some digging and get back to you.

gavirawson-apple commented 1 year ago

Are you able to upload your app to the App Store despite this warning? Or is it blocking you from uploading the app?

drdavec commented 1 year ago

Gavi, I also receive this warning. I can successfully upload my app to Connect for TestFlight use, but have not tried getting approval for release on the App Store.

Thanks, Dave

On Thu, Nov 17, 2022 at 10:00 AM Gavi Rawson @.***> wrote:

Are you able to upload your app to the App Store despite this warning? Or is it blocking you from uploading the app?

— Reply to this email directly, view it on GitHub https://github.com/carekit-apple/CareKit/issues/672#issuecomment-1318933287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKEBNHKKMZ2CVOBZKOC2NALWIZQCPANCNFSM6AAAAAARG4Q32M . You are receiving this because you are subscribed to this thread.Message ID: @.***>

gavirawson-apple commented 1 year ago

Thanks @drdavec, it's helpful to know how many folks are impacted by this issue. Let me know if this becomes a blocker for uploading your apps to the App Store. At the moment this seems to me like it's not specific to CareKit, and may get ironed out in Xcode. But let me know if this does become a big blocking issue.

majidsaleem105 commented 1 year ago

@gavirawson-apple

We also receive this warning on uploading.
But it allows us to upload the app with warnings to the TestFlight, and it also successfully gets approved by the review team to publish it into the store.
No warning or blocking from the app store.

It may help you to figure out the issue.