search

carekit-apple / CareKit

CareKit is an open source software framework for creating apps that help people better understand and manage their health.
https://www.researchandcare.org
Other
2.41k stars 444 forks source link

Fix ios platform in .spi.yml #697

Closed finestructure closed 1 year ago

finestructure commented 1 year ago

Hi @cbaker6 , our documentation test picked up that docs aren't properly generated for the package and the reason is probably the duplicate platform: ios entry in .spi.yml. This should fix that.

finestructure commented 1 year ago

Mmm, I kinda feel like I've done this before but I can't find a PR like it. Maybe it was in another repo? 😅

cbaker6 commented 1 year ago

Yup, we discussed the fix in https://github.com/carekit-apple/CareKit/pull/696#issuecomment-1535594980, but it hasn’t been merged yet

finestructure commented 1 year ago

Ah, I see, it wasn't a PR dedicated to this change. I'll go ahead and close this again, sorry for the noise!

gavirawson-apple commented 1 year ago

Hey @finestructure! Thanks for tracking down the issue, do you mind reopening up this PR? We can integrate this quick fix to get the documentation deployed to SPI.

gavirawson-apple commented 1 year ago

I may be able to reopen it on my end, let's see...

finestructure commented 1 year ago

Re-opening is greyed out for me but I've just opened a new one: https://github.com/carekit-apple/CareKit/pull/706

Hope that helps!

gavirawson-apple commented 1 year ago

Incredible, thanks @finestructure!