Save and Load game bug

[mapedorr]

Bug description

Based on a message by @anthonyirwin82 in Discord's 🐞 | bugs channel.

• If you have a game you save after state.visited_first_time has run then load the game again it will run the code despite already being visited.
• When you load a game most users would expect the menu to disappear and be in the loaded game.
• When you save a game most users would expect the menu to disappear and be back in the game.

https://github.com/carenalgas/popochiu/assets/4536477/43c65be9-c91c-49fd-bab3-7ee9b316bc88

Video provided by Anthony.

Steps to reproduce

1. Make the character say something when the room is visited for the first time.
2. Save the game.
3. Load the game.
4. The character will say the lines despite the game was saved after it says them (after the room was already visited).

Expected vs observed behavior

The visited_first_time state property should be stored when the game is saved.

Environment information (please complete):

• OS type and version: Arch Linux
• Godot version: 4.2.2
• Plugin version or branch: Beta 3

[anthonyirwin82]

I think the problem is that the state.visited_first_time is still true and has not been set to false by popochiu. If you manually change the value it does save it and the cutscene does not play.

[mapedorr]

Thanks for the clarification. I'll work on this issue tomorrow.