carenalgas / popochiu

Godot plugin to make point n' click games in a similar way to tools like Adventure Game Studio and Power Quest.
MIT License
177 stars 18 forks source link

Duplicated props: prevent accidentally deleting everything. #248

Open papernoise opened 1 month ago

papernoise commented 1 month ago

Description of the current functionality

Currently when duplicating a prop, it will appear multiple times in the Popochiu dock's prop list. But of course all duplicated props will be instances of the same prop scene.

Why could this be problematic?

You might forget about these props being instances and not separate scenes as is usually the case. The UI currently does nothing to inform you about the nature of the props. If you delete one of the instances in the dock and select to delete relative files in "res://game/…" your prop will be gone and Godot will throw some errors.

Proposed solution

It is useful to have them as separate items in the list, because they might use different scripts, so I would add a symbol next to duplicated props informing that these are "shared instances".

Expected benefit of the requested feature

That you don't accidentally delete your props.

Alternatives I've considered

The only alternative I can see is to show only one item in the dock, but that will reduce the functionality a bit.

Additional context

Example mockup for 5 instances of the same prop.

image

mapedorr commented 1 month ago

I like what you propose for the icon. I wonder if we should also show them with some kind of indentation (like the one you see in the scene tree when a node is child of another one).

Maybe the context menu should show an option to break that inheritance and make one of those props an individual one.