carenalgas / popochiu

Godot plugin to make point-and-click adventure games, inspired by tools like Adventure Game Studio and PowerQuest.
https://carenalgas.github.io/popochiu/
MIT License
207 stars 19 forks source link

issue_345 Set a room script name if one wasn't set #346

Open balloonpopper opened 1 week ago

balloonpopper commented 1 week ago

Fixes https://github.com/carenalgas/popochiu/issues/345

I'm assuming the state will always have the name based off what I saw in testing. If this isn't a valid assumption, maybe it would be better to crash the game with an error message if the script name for a room is not set.

balloonpopper commented 1 week ago

The current code doesn't solve all the problems. The "tool" scripts have the buttons for creating props/hotspots etc all greyed out if a scene without a script name is loaded. The only way to fix it is to give the scene a script name, then reload the scene. Not sure how to fix this so that (1) the user knows the missing script name is the reason the buttons are all greyed out (it's printed on the console, but you might have the console window closed), and (2) to avoid the need to reload the scene to fix the problem.

mapedorr commented 5 days ago

This looks like a nice patch, but the real fix to this issue will be making sure rooms are created with their corresponding script_name. What might be happening is that the rooms are being created incorrectly in Godot 4.4.dev3. Before approving the PR, I’d like to take a look at that to see if there’s anything else we need to fix.