search

careteditor / issues

Caret issues
https://caret.io
326 stars 12 forks source link

Last whitespace character in a link displayed as `%20` in preview when certain characters used in previous links #367

Closed dealingwith closed 7 years ago

dealingwith commented 7 years ago

I use Caret to edit Jekyll posts, which allow for {{site.baseurl}} variables, which I use inside internal links in case I ever move the blog:

screen shot 2017-05-13 at 9 52 55 am

Prior to the most recent update, these links did not preview correctly (they would not be formatted into links, I would see all the raw markdown). I just updated and now they display (they do not link anywhere, which is expected--Caret could have no idea how to handle that variable), which is great!

Now there is just one more odd bug...external links following the above nicely formatted link text end up with %20 for spaces in only the last contiguous whitespace character(s) of their text:

screen shot 2017-05-13 at 9 44 55 am screen shot 2017-05-13 at 9 56 45 am screen shot 2017-05-13 at 9 59 34 am
dealingwith commented 7 years ago

Note that this only happens if there are links with the {{site.baseurl}} variable in the document. All links in documents without them are fine.

dealingwith commented 7 years ago

Also note that is only links that occur after the variable that are affected.

screen shot 2017-05-13 at 10 04 50 am
dealingwith commented 7 years ago

Also note that other links with the variable are not affected! 😄

screen shot 2017-05-13 at 10 08 24 am
dealingwith commented 7 years ago

These %20 whitespace characters also show up in the PDF export.

astoilkov commented 7 years ago

This is now fixed in the latest Caret 2.1.3 release.

Closing this issue. Thank you for reporting.

joshuaiz commented 6 years ago

I'm using the 4.0.0beta9 and this issue is still there:

screen shot 2018-03-12 at 10 21 04 pm
joshuaiz commented 6 years ago

Just to follow up, deleting the links and then undoing all the deletions seems to fix this but then it brings up the 'Cannot find module 'emojis' - 4.0.0-beta9 #669' issue so I think these are related.

I'd be happy to have a setting to disable emojis entirely until these bugs are worked out.

astoilkov commented 6 years ago

The emojis error will be fixed in the next release. We will also take a look at the link issue.