careteditor / issues

Caret issues
https://caret.io
325 stars 12 forks source link

Window Rendering Glitches: Caret 4 rc8-rc12 on Windows 10 #765

Open netmasteroc3 opened 6 years ago

netmasteroc3 commented 6 years ago

I'm seeing a couple of odd glitches with Caret 4 beta on Windows 10 Pro 64-bit.

System Info: Windows 10 64-bit version 1803 build 17134.112 Caret 4-rc12

I first saw these issues in rc8. Before opening this ticket, I uninstalled Caret 4 and downloaded and installed the latest version (rc12).

Bug 1: Maximize, Restore, Maximize Border Padding Issue

Steps to reproduce:

  1. Maximize Caret
  2. Restore Caret (click maximize/restore button again)
  3. Maximize Caret

What I expect:

Caret should maximize to the screen dimensions the same way both times.

caret-correct Crop of the top edge of the display showing how I expect it to look (and how it looks half the time).

What happens:

On the second (or specifically every other time) time Caret has gap and a thick white border (most obvious in dark mode) along the top of the screen.

caret-bad Crop of the top edge of the screen showing the improper rendering. Notice the white line and few pixels of the icons showing above it.

Bug 2: Typewriter Mode Enter Glitch

Steps to Reproduce:

  1. Enable typewriter mode
  2. At the top of a document press enter more than once.

What I expect:

The cursor should remain in the vertical center of the screen.

What happens:

The cursor moves down the screen until I start typing, then recenters on the first non-new-line character typed.

caret-typewriter-error

After 13 new lines are typed, the cursor becomes vertically centered as expected and will function properly for the rest of the document below that point.

Bug 3: Dark Mode Color Change

Steps to Reproduce:

  1. Start Caret in dark mode

What I expect:

Caret's background color should remain the same.

What I see

Caret starts with a more bluer gray background then shifts to a more neutral gray (see attached),

color-shift

The right side of the above image is the color of Caret before it's done loading, the left side is the color it shifts to.

Bug 4: Odd Banding in Dark Mode

Steps to Reproduce

  1. Close all open documents while in dark mode.

What I expect

Caret should be uniformly colored as it is when a document is open.

What I see

Caret has odd colored bands horizontally across the window.

caret-banding

astoilkov commented 6 years ago

Hi @netmasteroc3,

Thank you so much for the detailed description on all of the issues. We have logged them internally. You could expect a fix.

Regarding the Maximize, Restore, Maximize Border Padding Issue - Where is your toolbar positioned?

netmasteroc3 commented 6 years ago

Regarding the Maximize, Restore, Maximize Border Padding Issue - Where is your toolbar positioned?

What/which toolbar?

The Windows taskbar is on the bottom of the screen.

astoilkov commented 6 years ago

Sorry. I meant taskbar.

Thanks for the info.

netmasteroc3 commented 6 years ago

As an update to my bug 1. There appears to be some resizing calculations being run when the window is restored from the maximized state that is erroneously being fired (or a flag is being set and not unset under some conditions) 50% of the time. I can see the window shifting after it's size is restored to the previous non-maximized state.

However, if I restore the window by pressing win+left/right (which shifts the maximized window to use the full height left side of the screen), and then to the normal window by pressing win+right/left (the opposite of the previous key), the window doesn't get into the odd state and instead behaves normally all the time.

netmasteroc3 commented 5 years ago

Just an update to the second listed bug, the typewriter mode one, I'm seeing this in RC22 on Mac OS (Mojave) too.