carfup / PCFControls

PCF Controls available for Model Driven Apps in order to enhance the out of the box capabilities !
GNU General Public License v3.0
35 stars 19 forks source link

Idea: Not showing fields when the Quick View field is marked no visible #78

Closed nfcu-aldogarcia closed 3 years ago

nfcu-aldogarcia commented 3 years ago

Hi Clement,

I am working as part of the development team in my current company and we found out the QuickEditForm PCF custom control and it is amazing!

I downloaded the source code for the branch where it has the 1.3.2.1 tag, and I imported in my sandbox instance for a proof of concept. I found out the QuickEditForm is showing fields where they are configured for not being visible by default, and I proceeded to modify the source code in order to not show in the PCF custom control fields that are marked as not visible by default.

Due to this PCF control is under Open Source, we would like to know if there is anything else that you would require from us for using your control in addition to commit the change that I implemented. The development team is planning to use this control internally in the company for a few projects with no intention to redistribute to anyone else.

Regards, Aldo Garcia

carfup commented 3 years ago

Hello Aldo,

Thanks for your great feedback here. I'm working on a near future release and I can definitely integrate this into it. As you wish, either i do on my end or you send me a PR.

Regards

nfcu-aldogarcia commented 3 years ago

Thanks for your response Clement.

You will see my PR #79

Regards

carfup commented 3 years ago

PR Included in the next release (1.3.3.2 which should come up next week if I don't have additional things to do on it !)

Thanks a lot

carfup commented 3 years ago

Fix is included in the latest release : https://github.com/carfup/PCFControls/releases/tag/1.3.3.2 Enjoy !