Move some workspace crates into a separate repository

cargo-bins / cargo-binstall

Binary installation for rust projects

GNU General Public License v3.0

1.43k stars 52 forks source link

Move some workspace crates into a separate repository #1592

Open NobodyXu opened 5 months ago

NobodyXu commented 5 months ago

Move:

[x] leon and leon-macros into one repository leon
[ ] atomic-file-install
[ ] fs-lock
[ ] normalize-path
[x] simple-git
[ ] cargo-toml-workspace

Rationale:

they are not.strongly coupled with cargo-binstall
they rarely update
they can be reused outside cargo-binstall easily
improve caching since rust-cache doesn't cache workspace to reduce cache size

passcod commented 5 months ago

I think if we're going to split let's split all the atomic-file-install, fs-lock, and normalize-path into their own individual repos. They're not really related to each other.

NobodyXu commented 5 months ago

Yeah that makes sense.

passcod commented 5 months ago

while i'm here, leon Template should support ToOwned to convert all the borrowed cows into owned ones

NobodyXu commented 5 months ago

Yeah, I can add that function when koving them to a separate repo

NobodyXu commented 5 months ago

@passcod std::borrow::ToOwned is implemented for T: Clone, though <Cow as Clone>::clone returns a copies of the Cow::Borrowed.

I could manually implement <Template as Clone>::clone to convert Cow::Borrowed to Cow::Owned, but I feel that it is a breaking behavior.

Maybe we could add an associated fn to_owned to leon::Template?

P.S. I've already moved the code into a new repository https://github.com/cargo-bins/leon

passcod commented 5 months ago

I think we might as well issue a breaking change implementing ToOwned 'correctly'

NobodyXu commented 5 months ago

created cargo-bins/leon#4 to further discuss this