search

cargo-bins / cargo-binstall

Binary installation for rust projects
GNU General Public License v3.0
1.62k stars 60 forks source link

Add new option to `--disable-telemetry` to disable quickinstall statistics collection #1831

Closed NobodyXu closed 3 months ago

NobodyXu commented 4 months ago

Fixed #1822

NobodyXu commented 4 months ago

cc @azenla I've added the option --disable-quick-install-stats, does it look good to you?

NobodyXu commented 4 months ago

cc @passcod I've not sure how to add e2e-test for this feature, unless we do a MITM attack?

passcod commented 4 months ago

Maybe call it --disable-telemetry in case we add other telemetry and so it's clearer what we're doing? Plus could be good to add an env var so someone can opt-out for the entire machine.

passcod commented 4 months ago

Fine not to e2e test imo

azenla commented 4 months ago

I think the rename to --disable-telemetry would be good, I also would like to indicate support for an environment variable as disabling it globally would be valuable. I'd also like to ask if this can be done on quick install directly too, just for those that may use that.

Thanks!

NobodyXu commented 4 months ago

Thanks, updated the option to --disable-telemetry