Loggly Alert: cm-janus fatal error

[cargomedia-bot]

https://cargomedia.loggly.com/search/?terms=tag%3Acm-janus+AND+json.level%3Afatal&source_group=&savedsearchid=206843&from=2016-04-26T19%3A37%3A28Z&until=2016-04-26T19%3A42%3A28Z

{"level":"fatal","message":"Unexpected rejection error.","exception":{"type":"Error","message":"zlib binding closed","stack":"Error: zlib binding closed
    at DeflateRaw.Zlib._transform (zlib.js:493:15)
    at DeflateRaw.Transform._read (_stream_transform.js:167:10)
    at DeflateRaw.Transform._write (_stream_transform.js:155:12)
    at doWrite (_stream_writable.js:300:12)
    at clearBuffer (_stream_writable.js:407:7)
    at onwrite (_stream_writable.js:339:7)
    at WritableState.onwrite (_stream_writable.js:89:5)
    at afterTransform (_stream_transform.js:79:3)
    at TransformState.afterTransform (_stream_transform.js:54:12)
    at Zlib.callback (zlib.js:623:5)"},"hostname":"janus2.","timestamp":"2016-04-26T19:41:17+00:00"}

[vogdb]

This bug is not an easy target. We don't use zlib directly but multiple dependencies do. It might take a big pile of time to find the cause dependency. Should we track down this bug?

[njam]

Looks like this: https://github.com/websockets/ws/issues/628

There's a fix in ws 1.0 (https://github.com/websockets/ws/pull/632). Can we upgrade to see if it helps? There's even 1.1.0 now.

[vogdb]

ok, I should have googled this error, I see :) thank you

[codecov-io]

Current coverage is 100%

Merging #255 into 0.8.1 will increase coverage by +13.19%

@@           0.8.1      #255   diff @@
======================================
  Files         34        34          
  Lines       1259      2070   +811   
  Methods        0       321   +321   
  Branches     135       170    +35   
======================================
+ Hits        1093      2070   +977   
+ Misses       116         0   -116   
+ Partials      50         0    -50   

1. 4 files (not in diff) in lib/job/model were modified. more
   • Misses -10
   • Partials -8
   • Hits +133
2. 5 files (not in diff) in lib/job were modified. more
   • Misses -6
   • Partials -3
   • Hits +80
3. 5 files (not in diff) in lib/janus/plugin were modified. more
   • Misses -14
   • Partials -4
   • Hits +124
4. 6 files (not in diff) in lib/janus were modified. more
   • Misses -51
   • Partials -21
   • Hits +275
5. 2 files (not in diff) in lib/global were modified. more
   • Misses -5
   • Partials -2
   • Hits +32
6. 11 files (not in diff) in lib were modified. more
   • Misses -30
   • Partials -12
   • Hits +333

Powered by Codecov. Last updated by 6464706

[vogdb]

I still can't check it locally on my dev machine :(. @njam Should we try to release as it is now?

[njam]

You mean you can't reproduce the issue? Since this happens only occasionally it's probably difficult to reproduce, so I agree to release it to production to verify.

[vogdb]

@njam merging FYI