Closed tomaszdurka closed 8 years ago
@tomaszdurka please review
- intercept context-data sent from CM application (similar to websocket)
@tomaszdurka please tell the format of this context-data. When we receive a response from CM we take its 'success' field as the result.
return response['success']['result'];
Under what field name we should expect CM context-data?
Yes, we need issue for CM to send this data. Just created it https://github.com/cargomedia/cm/issues/2154.
Let's expect this data to come in context
get parameter. Exactly the same as in websocket server https://github.com/cargomedia/cm-janus/blob/master/lib/janus/connection.js#L166
This way we may be consistent for all types of requests (GET/POST, etc).
@tomaszdurka please look. Not sure about this delete response['context'];
but otherwise we log it twice.
@@ 0.8.5 #262 diff @@
==========================================
Files 34 34
Lines 1316 1318 +2
Methods 324 324
Messages 0 0
Branches 142 143 +1
==========================================
+ Hits 1190 1191 +1
- Misses 126 127 +1
Partials 0 0
Powered by Codecov. Last updated by 8e5228c...2e9f9c7
@tomaszdurka please review
Looks good ;)
Will merge and release tomorrow
debug
toinfo
(https://github.com/cargomedia/cm-janus/blob/ceef69f6ff34e1db4077567a29e3acabd1676fe9/lib/http-server.js#L47)