search

cargomedia / cm-janus

UNMAINTAINED. cm/janus bridge
MIT License
2 stars 6 forks source link

Update uuid to version 3.0.0 #290

Closed marcbachmann closed 7 years ago

marcbachmann commented 7 years ago

Version 3.0.0 of uuid just got published.

Hi there,

This week a new version of the uuid module got released. The old module which was available by the name node-uuid got deprecated and will show error message upon every install of the module.

To get rid of those install errors I've created this automated pull request. I've run some checks against your code base to test whether you're using one of the deprecated apis, but this isn't the case.

Please test the changes against your code. I didn't run any tests and therefore can't guarantee that it isn't breaking. You can also just close this pr if you don't want to update your module.

In case there's already another pr open to upgrade uuid, I'm sorry for the effort I'm causing.

vogdb commented 7 years ago

@tomaszdurka @njam shall we apply the changes? Skip them for now cause everything works fine and better to do not touch it while it works?

njam commented 7 years ago

I would apply the upgrade, seems simple enough and we have good test coverage. Could you cut a release?

vogdb commented 7 years ago

thanks @marcbachmann !