Closed njam closed 9 years ago
I put a waiting
label because until I will have a proper Android emulators, I'm not able to recreate the necessary environment to reproduce the above errors or to test whether these errors have gone due to my fix.
Ok. We had problems because the devices you mentioned above didn't support HTML5 date. As an example lets take Android 4.0.3, 4.2.2, 4.3.1 and their default browser. It does not support HTML5 date and suggests by default a value --
.
We have several options but all of them about narrowing down the set of devices where we enable HTML5 date. IEMobile can not be tested properly, it's hard to get their emulators, so I suggest to remove it in the first place.
Android default browser implement HTML5 date since 4.4. So, we can either cut the usage of Android to this version or exclude it totally. I think the answer to this is on our user stats. How many users do we have among Android 4.4 and higher? According to the info here https://developer.android.com/about/dashboards/index.html it shares 33% of the Androids.
@njam thoughts?
@christopheschwyzer please share your thoughts too.
Android stats:
Even usage is still very low, I would narrow the implementation down to Android 4.4 and up. It's the future!
Very fun. This issue now depends on #1558 because of ftlabs/fastclick#160.
I found a very interesting info at http://caniuse.com/#search=date. Pay attention to an asterisk sign *
in iOS Safari
column header. It tells that iOS Safari
in iOS7.1 does not support max
and min
attributes. I checked iOS8.1 + iPhone5/5s/6. They do not support these attributes too! It makes our birthdate field inconvenient to use. Users are forced to roll their year from 2014 all the time.
I think we should drop this update for a time being because the only devices that support it is Android 4.4 and higher.
@njam @christopheschwyzer ?
ok with me
@njam You forgot about this one.
Hmmm, agree. But then I'm under the impression it might be too early to do what we're trying here. Also I can't find any other web site from a big company using the date selection on mobile. How about we postpone this?
As agreed by all of the contributors I close this issue until good times will come.
Added: https://github.com/cargomedia/CM/pull/1305 Reverted: https://github.com/cargomedia/CM/issues/1508
Firefox 32 (might be selenium bot?)
Windows Phone 8.1
Android 2.3
Android 4.0
Android 4.2