cargomedia / cm

UNMAINTAINED - CM web application framework
MIT License
12 stars 18 forks source link

FB-115 Change App Url format #2635

Closed zazabe closed 7 years ago

zazabe commented 7 years ago
zazabe commented 7 years ago

@{c7e8ab9c-90bf-4796-bb88-9aa7c8150044,Reto Kaiser} here we are... this is the challenging PR i told you, about https://youtrack.cargomedia.ch/issue/FB-115...

njam commented 7 years ago

There are some problems with setUrlFromString(), which needs to instantiate a specific type of URL. This is needed so that later the Request::getUrl() can be used to generate correct URLs. Unfortunately there are way to many dependencies in this area of code (Request, Response, URL, etc), and it's uncertain if it makes sense / is possible to refactor it.

One idea would be to cut the dependencies at CM_Http_Response_Abstract, by ensuring it doesn't receive the Request.

njam commented 7 years ago

Idea: