FB-931 Add new site-config "robots-noindex" option

cargomedia / cm

UNMAINTAINED - CM web application framework

MIT License

12 stars 18 forks source link

FB-931 Add new site-config "robots-noindex" option #2654

Closed alexispeter closed 7 years ago

alexispeter commented 7 years ago

I saw you added new properties as optional and made it so they don't even need to exist in the document. I didn't really see why, so I added this one normally. I hope this doesn't break something that I'm not aware of.

fvovan commented 7 years ago

~~Please don't forget to include it to SK_Site_Abstract::_getschema() as well. I thought about correct composition of these schemas to avoid the duplication but then we postponed it for now.~~ Ahh. there's another PR

fvovan commented 7 years ago

It was needed to instantiate models in migration. Otherwise I would have had to use mongoDB directly and it would have increased the probability of errors. But in general we plan to discuss the optionality of all fields. I tend to make them all mandatory.