search

cargomedia / cm

UNMAINTAINED - CM web application framework
MIT License
12 stars 18 forks source link

Track FastClick pull request #456

Closed kris-lab closed 8 years ago

kris-lab commented 11 years ago
njam commented 11 years ago

Please add a link to the PR and to the commit where the changes were applied in our project.

kris-lab commented 11 years ago

See also: Pull request: https://github.com/ftlabs/fastclick/pull/103 CM commit: https://github.com/kris-lab/CM/commit/054508f5d50a6dd2972f54aa8b6ae6965b3dee9c

njam commented 11 years ago

@kris-lab can you also add a short description why we did https://github.com/ftlabs/fastclick/pull/103 in there, and maybe link it to their issue they have, to make their life easier, and increase the chances of getting it merged?

vogdb commented 10 years ago

@kris-lab There were some discussion about this and ftlabs/fastclick#289 PR was done already. This PR solves our problem and it is made from fresh master, so it doesn't require additional merging. I guess now Fastclick's author waits for your response on your PR. So could please just write there that you prefer to close your PR in favor of the new one.

tomaszdurka commented 10 years ago

@kris-lab any news on this one?

kris-lab commented 10 years ago

Hard to say. let's wait if is done what here https://github.com/ftlabs/fastclick/pull/103#issuecomment-53962054

vogdb commented 10 years ago

We are waiting for ftlabs/fastclick#289 I think it would be much faster to create our patched fastclick and use it until ftlabs/fastclick#289 is merged

vogdb commented 10 years ago

@tomaszdurka So what do you think about using our own patched version.

njam commented 10 years ago

@vogdb we are using a patched version, see: https://github.com/cargomedia/CM/blob/master/client-vendor/after-body/fastclick/fastclick.js#L1

This issue is just to track the progress of getting it merged upstream. So hopefully one day we can go back to the original upstream version. (the problem we custom patched versions is that sometimes when we upgrade the library it gets forgotten to patch it again..)

vogdb commented 10 years ago

Sorry. I didn't see that.

vogdb commented 9 years ago

I guess we will never see the patch =( ftlabs/fastclick#308

stophecom commented 9 years ago

It's now in https://github.com/ftlabs/fastclick/pull/308 ;)

tomaszdurka commented 8 years ago

We're not using FastClick anymore.