Deploy test boxes without influencing test outcome

cargomedia / puppet-packages

UNMAINTAINED. Reusable puppet modules for Debian

MIT License

7 stars 16 forks source link

Deploy test boxes without influencing test outcome #993

Closed ppp0 closed 8 years ago

ppp0 commented 8 years ago

E.g

We do require apt::upgrade in provision.pp right now but this influences the outcome of testing different apt transports

May be deploy boxes with a shell script? Postpone first puppet execution to the test spec?

To be discussed @tomaszdurka

@njam @kris-lab cc

njam commented 8 years ago

I would suggest to do a shell script, should be pretty simple!

ppp0 commented 8 years ago

+1 for shell provisioning

tomaszdurka commented 8 years ago

As discussed this ain't so simple.

Before we do tests we require a few specific package, configurations to be present.

polipo (for caching)
puppet (common entities needed in order to run puppet apply correctly)

We also require apt-update, but that is only for some performance reasons - which imo we should skip.

tomaszdurka commented 8 years ago

We are afraid that by applying puppet modules we might modify 3rd party things. With shell script we could have exact same problem. So instead of making provisioning in the shell script I would propose to make sure those scripts are isolated and don't install 3rd party things. Maybe we should add some specs, to make sure they don't trigger apt-get updates, etc.

ppp0 commented 8 years ago

Somewhat agree

for performance reasons we require polipo and for nothing else
apt-get upgrade is required in order to always use the same (latest) set of packages

I would opt for not using puppet to provision the box but only when spec testing (ie applying the manifests we want to test).

Also discussed was to only deploy the modules listed in Puppetfile in order to make sure it contains all needed dependencies

tomaszdurka commented 8 years ago

Will be solved in #997