search

caribou / caribou-frontend

Page routing for caribou projects
1 stars 2 forks source link

No rendering of admin login page #3

Open vasilism opened 10 years ago

vasilism commented 10 years ago

Operating system: windows 7

lein -version Leiningen 2.3.2 on Java 1.7.0_40 Java HotSpot(TM) 64-Bit Server V

lein new caribou tundra cd tundra lein caribou migrate resources/config/development.clj lein ring server

curl http://localhost:33333/_admin/login No template by the name login.html

noisesmith commented 10 years ago

This is not reproducible currently on a Linux or OSX machine.

This appears to be a Windows specific issue, but currently we don't have a windows dev machine.

I'll update here if we can make any progress on this (any help from a Windows dev is appreciated). I assume this is related to the way we look for embedded template resources in library jars.

vasilism commented 10 years ago

(caribou.app.template/path-for-template "login.html") "templates\login.html"

(clojure.java.io/resource "templates\login.html") nil

(clojure.java.io/resource "templates/login.html") URL jar:file:/C:/Users/vasilism/.m2/repository/caribou/caribou-admin/0.13.0/caribou-admin-0.13.0.jar!/templates/login.html

so if dont use the system file seperator when loading a template this will solve the problem.

noisesmith commented 10 years ago

Thank you very much, this should not take too long to sort out.

noisesmith commented 10 years ago

I am working on getting my hands on a Windows machine for testing, but in the meantime if you would like to try out a first attempt at addressing this issue you can check out the win-compat branch of caribou-core and run lein install, after which your existing project will use the new local version.

Of course if this is too much trouble, I will continue working on verifying from my end once I procure a windows box. I would like caribou to be fully cross-platform compatible, and my suspicion so far is this issue is a fairly shallow bug.

noisesmith commented 10 years ago

I verified that the fix works on Windows, and does not cause a regression with asset upload or serving assets to clients. Pull request issued and recommended for immediate merge to caribou-core. This fix should be present in the next jar we deploy for caribou core, and be pulled in by the next caribou/lein-template