carissalow / rapids

Reproducible Analysis Pipeline for Data Streams
http://www.rapids.science/
GNU Affero General Public License v3.0
37 stars 20 forks source link

Barnett’s location features run into problems when INCLUDE_PAST_PERIODIC_SEGMENTS is set as True #126

Closed OrsonXu closed 3 years ago

OrsonXu commented 3 years ago

Describe the bug When INCLUDE_PAST_PERIODIC_SEGMENTS is set as True in the time segment configuration, seems like Barnett’s location features will be calculated multiple times but displayed as the same local_segment_start_datetime and local_segment_start_datetime.

To Reproduce Steps to reproduce the behavior:

  1. Set INCLUDE_PAST_PERIODIC_SEGMENTS as True
  2. Specific periodic time segmentation setup: daily_14dhistory,00:00:00,13D 23H 59M 59S,every_day,0
  3. Set Barnett’s location feature as True in the config.yaml
  4. Run RAPIDS

Expected behavior The first time segments will be repeated 14 times in the phone_locations.csv.

Screenshots image

Please complete the following information:

JulioV commented 3 years ago

Thank you for reporting this. I forgot to close this issue earlier, as discussed on Slack this has been fixed in v1.0 https://github.com/carissalow/rapids/commit/d0858f88332f8f07306e500d310cadbd31bd92ef