[PHONE_CONVERSATION][PROVIDERS][RAPIDS] feature calculation bug.

carissalow / rapids

Reproducible Analysis Pipeline for Data Streams

http://www.rapids.science/

GNU Affero General Public License v3.0

37 stars 20 forks source link

[PHONE_CONVERSATION][PROVIDERS][RAPIDS] feature calculation bug. #133

Closed yiyir closed 3 years ago

yiyir commented 3 years ago

Describe the bug In /rapids/src/features/phone_conversation/rapids/main.py line 11: Calculation of expected total duration assumes that the length of the current time segment is 1 day (1440 minutes).

Features related: silenceexpectedfraction, noiseexpectedfraction, voiceexpectedfraction, unknownexpectedfraction

Expected behavior Should not hardcode the length of the time segment(avoid magic numbers like 1440); instead, infer from the “length” column of time_segment.csv file

JulioV commented 3 years ago

Thanks Yiyi, @nikunjgoel95 can you take a look at this, please?

JulioV commented 3 years ago

Thanks for the report @yiyir this is now fixed in 9b21196f35317872d2fa8a87efa826bdd1e5be1d