search

carissalow / rapids

Reproducible Analysis Pipeline for Data Streams
http://www.rapids.science/
GNU Affero General Public License v3.0
37 stars 20 forks source link

Fix phone applications foreground feature bugs #198

Closed jenniferfedor closed 1 year ago

jenniferfedor commented 1 year ago

Hi @JulioV and @Meng6, could you please review these changes related to issues #195 and #196 whenever you have some time? Our tests for phone_applications_foreground are currently failing because we've changed how some of those features are computed. If you're okay with those changes, we will update the test data accordingly.

jenniferfedor commented 1 year ago

Hi @JulioV, we've updated the tests for phone applications foreground and they are now passing. Are there any other changes you'd like me to make or are we ready to merge? Thank you!