Fix bug that resampled rows with columns out of order

carissalow / rapids

Reproducible Analysis Pipeline for Data Streams

http://www.rapids.science/

GNU Affero General Public License v3.0

37 stars 20 forks source link

Fix bug that resampled rows with columns out of order #207

Closed JulioV closed 1 year ago

JulioV commented 1 year ago

This PR fixes https://github.com/carissalow/rapids/issues/197. We also

Print a warning when rows cannot be assigned to a tz and so are discarded
Update docs

The bug:

readable_datetime process data in chunks
the problem ocurrred when processing data with multiple time zones and some of those rows of data could not be assigned to a time zone
in this case we would output columns in a different order compared to when rows were assigned to a time zone.

JulioV commented 1 year ago

@jenniferfedor if the tests pass, you approve the PR and we have the time for this cycle, can we merge and release this fix in this new version? Thank you!