search

carissalow / rapids

Reproducible Analysis Pipeline for Data Streams
http://www.rapids.science/
GNU Affero General Public License v3.0
37 stars 20 forks source link

Docker workflow run failing #208

Closed jenniferfedor closed 1 year ago

jenniferfedor commented 1 year ago

Hi @JulioV, we're preparing to release RAPIDS v1.9.2 but the docker workflow is failing. Specifically, it looks like there is an issue restoring the renv and the correct versions of the R packages we updated in renv.lock are not being installed (e.g., we updated cli to 3.4.1 but cli 2.2.0 is still being installed). @ChinW97 and I are not familiar with using Docker. Do you have any thoughts or suggestions of how we might approach fixing this? Thank you!

JulioV commented 1 year ago

The best place to start are the github action logs of the docker image build process. The ones from the most recent release are here. It seems that we need to either update all r libraries or remove the cli entry because there are version conflicts when installing broom.

In this case we don't need to modify the dockerfile (it exists in the root directory) because the problem is the renv restore.

I think the best option to test any changes that affect the docker image now and in the future would be to add a GitHub action that builds a test image on every push to a branch like the one that runs our tests. Alternative you can test a dockerfile locally I think.

jenniferfedor commented 1 year ago

Hi @JulioV, thank you so much for your suggestions! We inspected the logs further and found that the error restoring the R environment occurred due to an upstream issue where the build and push action failed to find the most recent commit on the master branch. We added a checkout action prior to the build and push action in our Docker workflow to fix this issue.