Feature: add listenbrainz submit

carl-di-ortus / gmusicbrowser

jukebox for large collections of music

http://gmusicbrowser.org

GNU General Public License v3.0

0 stars 0 forks source link

Feature: add listenbrainz submit #2

Open carl-di-ortus opened 2 months ago

carl-di-ortus commented 2 months ago

Listenbrainz support a compatibility for last.fm scrobbler, so a bare minimum adding this is very easy - just change the post URL. It would copy-paste ~300 lines of code. Dirty, but works. Better alternatives are a topic of discussion:

Add URL field in scrobbler settings (and rename old last.fm plugin to some more generic name like "audio scrobble"?), this will not allow having multiple scrobblers at once.
Rename last.fm plugin to generic "Audio scrobble" and introduce a multiple url+username+password sets for handling sumbits. Might save the code duplication, but complicate settings a slight bit.
Keep plugin separate, and implement listenbrainz API, don't use listenbrainz proxy compatibility. This would still have code duplication on firing/listening events.

carl-di-ortus commented 2 months ago

Last.fm scrobbler does not submit album info. So listenbrainz defaults to original release always.

Example - listening to a song from later live album, but recognized as from original album.

Thus, initial copy-paste scrobbler is not good enough. The first and second bullet points suggestion is not doing anything to improve the situation too. The third option is what I'm leaning towards to. Hardest work, but the most correct one.

carl-di-ortus commented 1 month ago

Plugin rewritten to use native listenbrainz API, however there are still bugs that I'm not happy about:

[ ] bug when album/artist/track in unknown
[ ] error in payload containing char '. we can try saving payload to file, and passing this to wget, or find a way to JSON escape strings.
[ ] duplicate NowPlaying posts on next song, triplicates on next song, quadruple on next, ...
[ ] check for regressions in http module, port(?) changes to other http modules? (how to even test them?)
[ ] (optional) Submit and NowPlaying happens instantly one after other, might be a cool feature, we might use this default 10s split between calls.
[ ] (optional, nice to have) use MBID and other extra tags

I intend to solve all non optional before marking this as PR ready. However, my progress here is rare and slow.