Closed rikMaz closed 5 years ago
f5maki
commented
5 years ago I have the same issue.
The problem was fixed initially in the fix_win32_compilation branch from IFusionzz but carla.h was subsequently changed and the branch was deleted when merged to master.
If carla.h includes EngineMinimal.h then the windows build compiles. e.g.
mhelleis
commented
5 years ago I have the same issue.
The problem was fixed initially in the fix_win32_compilation branch from IFusionzz but carla.h was subsequently changed and the branch was deleted when merged to master.
If carla.h includes EngineMinimal.h then the windows build compiles. e.g.
include "Util/NonCopyable.h"
include "EngineMinimal.h"
include "Logging/LogMacros.h"
include "Modules/ModuleInterface.h"
Hey @f5maki could you solve this problem with including EngineMinimal.h?
marcgpuig
commented
5 years ago @Atlunch @dieteekanne2
Faced the same problem in my personal machine. But found a solution, update your Visual Studio :) (Without the changes that @f5maki proposed works for me)
Visual Studio Installer (you can search it on the windows start menu)Visual Studio Community 2017f5maki
commented
5 years ago @marcgpuig Thanks for your help. There is still an issue with the *_Game configurations compiling master with 15.9.3.
mvgraf
commented
5 years ago I have the same issue. The problem was fixed initially in the fix_win32_compilation branch from IFusionzz but carla.h was subsequently changed and the branch was deleted when merged to master. If carla.h includes EngineMinimal.h then the windows build compiles. e.g.
include "Util/NonCopyable.h"
include "EngineMinimal.h"
include "Logging/LogMacros.h"
include "Modules/ModuleInterface.h"
Hey @f5maki could you solve this problem with including EngineMinimal.h?
Worked perfectly. Thanks!
mhelleis
commented
5 years ago @Atlunch @dieteekanne2
Faced the same problem in my personal machine. But found a solution, update your Visual Studio :) (Without the changes that @f5maki proposed works for me)
* Previous not working version was **15.6.0** * Current working version is **15.9.3**How to update Visual Studio Community 2017
1. Run the `Visual Studio Installer` (you can search it on the windows start menu) 2. Follow the instructions to update `Visual Studio Community 2017` 3. Restart Windows
hi @marcgpuig thank you. I still have errors. Here's what I did now exactly:
make launch
still I get the following error messages:
yyuuliang
commented
5 years ago There is a branch "fix_vs2017_build_solution", try this one. I am using win10 too, this branch works. It is 0.9.0. You have to manually run the setup.py in PythonAPI to build the PythonAPI. There is a folder PythonClient, this one doesn't compatible with the server, so don't use this.( just delete it for convenience)
mhelleis
commented
5 years ago There is a branch "fix_vs2017_build_solution", try this one. I am using win10 too, this branch works. It is 0.9.0. You have to manually run the setup.py in PythonAPI to build the PythonAPI. There is a folder PythonClient, this one doesn't compatible with the server, so don't use this.( just delete it for convenience)
Hey @yyuuliang thanks for your answer. I tried to build this branch, however I'm getting an error with the "b2.exe". Couldnt find anyting on GitHub regarding this error.
yyuuliang
commented
5 years ago What command did you use? It said "failed to write output file", so maybe you want to run it as administrator?
mhelleis
commented
5 years ago What command did you use? It said "failed to write output file", so maybe you want to run it as administrator?
Hey @yyuuliang thanks for your assistance, it is highly appreciated. I did run the x64 command prompt as administrator. First I used the 'make launch' command and the error occured. But the same error occurs whatever command I use (e.g make launch-editor, make PythonAPI). I'll a different computer and see how that goes. Have a geat weekend! I could not figure out what the b2.exe actually i
marcgpuig
commented
5 years ago Hi @Atlunch @f5maki @mvgraf @dieteekanne2 @yyuuliang
Due to the big amount of work and the difficulty of maintaining this project on both platforms, Carla on Windows is not currently working.
libpng.h and other image libraries are used to store images, but only works on Linux.
#pragma once
namespace carla {
namespace image {
class ImageIO {
public:
template <typename ImageT>
static void ReadImage(const std::string &, ImageT &) {}
template <typename ViewT>
static std::string WriteView(std::string out_filename, const ViewT &) {
return out_filename;
}
};
} // namespace image
} // namespace carlabut you can't save images from python using our functions.
Boost's Filesystem is not compiling on windows.
Since this PR #1008 Windows have other errors.
We will try to help you fixing this issues the most we can, but we can't focus on this right now. Our most sincere apologies.
mhelleis
commented
5 years ago Hi @Atlunch @f5maki @mvgraf @dieteekanne2 @yyuuliang
Due to the big amount of work and the difficulty of maintaining this project on both platforms, Carla on Windows is not currently working.
Localized Issues
* `libpng.h` and other image libraries are used to store images, but only works on Linux. * **Workaround:** You can replace ImageIO.h with this: ```c++ #pragma once namespace carla { namespace image { class ImageIO { public: template <typename ImageT> static void ReadImage(const std::string &, ImageT &) {} template <typename ViewT> static std::string WriteView(std::string out_filename, const ViewT &) { return out_filename; } }; } // namespace image } // namespace carla ``` but you can't save images from python using our functions. * **Possible solution:** use [stb_image.h](https://github.com/nothings/stb/blob/master/stb_image.h) and [stb_image_write.h](https://github.com/nothings/stb/blob/master/stb_image_write.h) instead. * **Possible drawbacks:** Impact on performance and compression quality. * Boost's `Filesystem` is not compiling on windows. * Needs further investigation * Since this PR #1008 Windows have other errors. * Needs further investigationWe will try to help you fixing this issues the most we can, but we can't focus on this right now. Our most sincere apologies.
Hello @marcgpuig thank you for the info!
Still getting these build errors. I read in Fix win32 compilation #988 that you have changed something. But still, I'm getting these build errors on win10. What shall I do?