carla-simulator / leaderboard

CARLA Autonomous Driving leaderboard
MIT License
164 stars 77 forks source link

OpenDRIVE data never retrieved when it is the only sensor. #169

Closed Daraan closed 5 months ago

Daraan commented 6 months ago

I wanted to check out the opendrive_map sensor but never got any input_data; not setting up other sensors for this purpose.

I tracked this bug down to this line of code that always aborts the data retrieval:

https://github.com/carla-simulator/leaderboard/blob/111a48f9099c08a2f1068ee8aea2ad56ce52ef9d/leaderboard/envs/sensor_interface.py#L230-L232

With only an opendrive_map sensor this is equal to 1 == 0+1 and always breaks -> returns empty dict.

Shortly also noted in #50

glopezdiest commented 5 months ago

@Daraan That does seem to be the case. We'll fix it ASAP

glopezdiest commented 5 months ago

The issue has been fixed with PR #174, which removed the reading frequency of the opendrive, allowing to avoid all of this convoluted (and incorrect) check