Remove deprecation warnings for version checking in 3.8 & 3.10+ (2.7 backward compatible)

carla-simulator / leaderboard

CARLA Autonomous Driving leaderboard

MIT License

164 stars 77 forks source link

Remove deprecation warnings for version checking in 3.8 & 3.10+ (2.7 backward compatible) #172

Closed Daraan closed 4 months ago

Daraan commented 5 months ago

Removes two deprecation warnings that come up in newer python version:

distutils will be removed in Python3.12, and marked as deprecated in 3.10 PEP 632
pkg_version, should not be used in newer versions of setuptools https://setuptools.pypa.io/en/latest/pkg_resources.html

This PR can still be used with older Python version that do not provide the new modules.

This change is

Daraan commented 5 months ago

It might also be nicer to move the version stuff into an extra file in utils or so. from utils import get_carla_version and have the try...except blocks there or use a different approach.

PabloVD commented 4 months ago

Thanks for the PR. Could you please do the PR to the master branch and change the minimum version to 0.9.15, which is the default version used in Leaderboard 2?

Daraan commented 4 months ago

Could you please do the PR to the master branch and change the minimum version to 0.9.15, which is the default version used in Leaderboard 2?

@PabloVD . Changed to master and 0.9.15