carla-simulator / ros-bridge

ROS bridge for CARLA Simulator
MIT License
513 stars 414 forks source link

updated ad_demo to cmake over python to fix #611 #613

Closed joe28965 closed 2 years ago

joe28965 commented 2 years ago

As the title says, ad_demo fails in ROS 2 Foxy due to some python issue.

The thing is, there is no python used in that launch file. It's some configs and launch files. I'm no expert at python (wouldn't even call myself a novice tbh), so I changed the CMakeLists and package.xml to use ament_cmake instead.

It's a simple fix. If there is a desire to keep using ament_python (not sure why it would be mandatory) LMK. However I won't be able to fix #611 in python.


This change is Reviewable