search

carla-simulator / ros-bridge

ROS bridge for CARLA Simulator
MIT License
510 stars 408 forks source link

KeyError: 'simple_pid.PID' in carla_ackermann_control_node.py #678

Open VishGit1234 opened 1 year ago

VishGit1234 commented 1 year ago

In carla_ackermann_control_node.py, the code sys.modules['simple_pid.PID'] on lines 58 and 74 throws a key error. After taking a look at the keys in sys.modules, the issue seems to be with the capitalization of PID. If the code is changed to ... sys.modules['simple_pid.pid'] it works just fine

lrstttl commented 8 months ago

@VishGit1234 it also works without code modifications by sticking to an older version of the simple-pid module, e.g. simple-id==1.0.1 instead of using the latest one (see https://github.com/carla-simulator/ros-bridge/blob/master/requirements.txt#L8C8-L8C8).