search

carla-simulator / scenario_runner

Traffic scenario definition and execution engine
https://carla-scenariorunner.readthedocs.io/en/latest/
MIT License
521 stars 358 forks source link

Contributing with Scenarios (OpenScenario) #636

Open lucasnmatias opened 4 years ago

lucasnmatias commented 4 years ago

Hi, I work at IVEX and recently we have worked with scenario_runner to build scenarios and make the safety assessment of the vehicles behaviors. To do so we have implemented some of the NHTSA Scenarios from CARLA challenge on OpenSCENARIO and we would like to contribute to CARLA making a PR with those OpenSCENARIO scripts of NHTSA Scenarios. So first we would like to know if you would be interested in this contribution, and if that is the case, how could we make a PR of it?

fabianoboril commented 4 years ago

Hi, this contribution sounds amazing and would be a great benefit for us and the community :) Regarding the PR: There are several options but the easiest is to fork the scenario_runner repo, commit your changes on a local branch in the fork, and then do a PR from that branch back to ScenarioRunner. https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

Would this work for you?

jimmyw404 commented 3 years ago

@lucasnmatias Would be interested in seeing this and would also be interested in hearing your process for creating these scenarios!

lucasnmatias commented 3 years ago

@fabianoboril yes it would work! Sorry for the delay, within some days I will make the PR. @jimmyw404 yes, we can discuss and I share the experience of the scenario creation process.

ajdroid commented 3 years ago

Hi @lucasnmatias, is this a PR I can find somewhere already? Thanks! :)