search

carlaKC / attackathon

utilities and instructions to run a lightning jamming attackathon
0 stars 6 forks source link

setup: use service name for armada addnode #61

Closed carlaKC closed 2 months ago

carlaKC commented 2 months ago

This PR fixes #55 for me, but I'm not sure that it's the correct way of going about it. Not sure how this broke in the first place, but perhaps something was renamed in warnet.

According to this I believe we should be using the service rather than the pod name to do the DNS query across namespaces?

carlaKC commented 2 months ago

@m3dwards does this look sane to you?

m3dwards commented 2 months ago

Yes this looks sane as things currently are in Warnet.

Just as a heads up we are debating internally whether to remove services and just use pod hostnames. The services allow for horizontal scaling and predictable naming. We aren't using horizontal scaling and because the pods are created with StatefulSets we get predictable naming anyway. So might be a layer of indirection that's unneeded.

The fact you are having to do this to make things work does give me pause on pod hostnames as I would have thought it should work as is.

carlaKC commented 2 months ago

The fact you are having to do this to make things work does give me pause on pod hostnames as I would have thought it should work as is.

Never fully got to the bottom of this, so it's possible that it's something on my end. Seemed like DNS resolution wasn't working between namespaces using pod names from what I could tell. It was working consistently until about a month ago, would be worth seeing whether somebody else can consistently reproduce before we weigh that takeaway too strongly.