search

carlcraig / tc-angular-chartjs

AngularJS directives for Chart.js
http://carlcraig.github.io/tc-angular-chartjs/
Other
233 stars 83 forks source link

Repair DI so that using ngStrictDi works #28

Closed Jevonius closed 9 years ago

Jevonius commented 9 years ago

Hello, only a small change: somewhere along the lines (we haven't updated from source since 1.0.2) the DI in the directives got lost, breaking ngStrictDI.

Hopefully this won't have broken any tests - I'm not set up with any of the test stuff on this machine.

carlcraig commented 9 years ago

Hi,

Thanks for this. There have been some changes since 1.0.2, but the DI is strict in the dist directory.

You can use dist/tc-angular-chartjs.js or dist/tc-angular-chartjs.min.js which will solve your ngStrictDI issues.

I think there needs to be an addition to the readme to make sure that the dist files are used over the src files.

Let me know if this solves your problems.

carlcraig commented 9 years ago

I will close this as the dist directory contains ngStrictDI compatible files.