Added click support on chart data

carlcraig / tc-angular-chartjs

AngularJS directives for Chart.js

http://carlcraig.github.io/tc-angular-chartjs/

Other

233 stars 83 forks source link

Added click support on chart data #53

Closed cstefanache closed 8 years ago

ducpham-agilityio commented 8 years ago

getSegmentsAtEvent is not available for Line and Radar charts.

cstefanache commented 8 years ago

Added support for line, radar and bars. Checked if functions exists rather than type checking in order to avoid string type equals.

ducpham-agilityio commented 8 years ago

Great. But it seems to be you missed changes for dist file.

cstefanache commented 8 years ago

Dist package built. At the moment the onclick function is assigned using & isolated scope - the listener will be attached on each chart because of the wrapping function. It can be changed to = if required

ducpham-agilityio commented 8 years ago

@carlcraig Could you help to review this MR?

carlcraig commented 8 years ago

Looks good, will publish a release soon.

carlcraig commented 8 years ago

Published version 1.0.13, thanks for the contribution :+1: