carlcraig / tc-angular-chartjs

AngularJS directives for Chart.js
http://carlcraig.github.io/tc-angular-chartjs/
Other
233 stars 83 forks source link

Fix compilation error with angular 1.5.0-rc.1 #56

Closed mrdevin closed 8 years ago

mrdevin commented 8 years ago

Upgrading to angular 1.5.0-rc.1 causes the following error

https://docs.angularjs.org/error/$compile/nonassign?p0=undefined&p1=tcChartjsBar

Error: [$compile:nonassign] Expression 'undefined' used with directive 'tcChartjsBar' is non-assignable! http://errors.angularjs.org/1.5.0-rc.1/$compile/nonassign?p0=undefined&p1=tcChartjsBar at angular.js:68 at parentSet (angular.js:9487) at parentValueWatch (angular.js:9500) at Object.regularInterceptedExpression (angular.js:15098) at Scope.$digest (angular.js:16538) at Scope.$apply (angular.js:16810) at done (angular.js:11186) at completeRequest (angular.js:11384) at XMLHttpRequest.requestLoaded (angular.js:11325)(anonymous function) @ angular.js:13156(anonymous function) @ angular.js:9885Scope.$digest @ angular.js:16564Scope.$apply @ angular.js:16810done @ angular.js:11186completeRequest @ angular.js:11384requestLoaded @ angular.js:11325 angular.js:11362 XHR finished loading: GET "http://localhost:3000/views/sidebar-notifications.html".(anonymous function) @ angular.js:11362sendReq @ angular.js:11155serverRequest @ angular.js:10865processQueue @ angular.js:15436(anonymous function) @ angular.js:15452Scope.$eval @ angular.js:16702Scope.$digest @ angular.js:16520Scope.$apply @ angular.js:16810done @ angular.js:11186completeRequest @ angular.js:11384requestLoaded @ angular.js:11325

Making the following scope properties optional upgrades compatibility.