search

carlcraig / tc-angular-chartjs

AngularJS directives for Chart.js
http://carlcraig.github.io/tc-angular-chartjs/
Other
233 stars 83 forks source link

Fix compile error for Angular 1.5.0-rc.1 #57

Closed mrdevin closed 8 years ago

mrdevin commented 8 years ago

upgrading angular causes the following error to occur for attributes that are not required

https://docs.angularjs.org/error/$compile/nonassign?p0=undefined&p1=tcChartjsBar

console output:

Error: [$compile:nonassign] Expression 'undefined' used with directive 'tcChartjsBar' is non-assignable!
http://errors.angularjs.org/1.5.0-rc.1/$compile/nonassign?p0=undefined&p1=tcChartjsBar
    at angular.js:68
    at parentSet (angular.js:9487)
    at parentValueWatch (angular.js:9500)
    at Object.regularInterceptedExpression (angular.js:15098)
    at Scope.$digest (angular.js:16538)
    at Scope.$apply (angular.js:16810)
    at done (angular.js:11186)
    at completeRequest (angular.js:11384)
    at XMLHttpRequest.requestLoaded (angular.js:11325)
carlcraig commented 8 years ago

Sorry about the delay looking into this PR. I decided to merge #59 as it had a few additional fixes for the chart-legend directive. Should hopefully be working now, please open another issue if there are problems.