search

carlcraig / tc-angular-chartjs

AngularJS directives for Chart.js
http://carlcraig.github.io/tc-angular-chartjs/
Other
233 stars 83 forks source link

Can't display chart for chart.js 1.1.1 #65

Closed spnettec closed 8 years ago

spnettec commented 8 years ago

Can not display chart any more when use chart.js 1.1.1. change line 114: chartObj.resize(); to chartObj.update();

resove this problem

tomsteg commented 8 years ago

Please fix it.

carlcraig commented 8 years ago

feel free to submit a PR for this, it should ideally still support object.resize() unless object.update() exists. I am not sure when I will have time to do this change myself.

joris-lambrechts commented 8 years ago

Hi @carlcraig,

I fixed the issue but I can't create a pull request with a tag as base. If you need anything, let me know.

Kind regards, Joris

carlcraig commented 8 years ago

Hi @joris-lambrechts I am happy to pull in the changes in your branch if you want?

Alternatively you might be able to use https://github.com/carlcraig/tc-angular-chartjs/tree/1.0 1.0 branch as a base to get the PR to work? The 1.0 branch is sitting at version 1.0.15 currently.

joris-lambrechts commented 8 years ago

Hi @carlcraig,

I used the 1.0 branch, works like a charm! https://github.com/carlcraig/tc-angular-chartjs/pull/72

Joris

carlcraig commented 8 years ago

Thanks for this fix on this.

I will close this issue now as v1.0.16 should solve this.