Chart.js 2 - Githubissues

carlcraig / tc-angular-chartjs

AngularJS directives for Chart.js

http://carlcraig.github.io/tc-angular-chartjs/

Other

233 stars 83 forks source link

Chart.js 2 #69

Closed joris-lambrechts closed 8 years ago

joris-lambrechts commented 8 years ago

Hi,

I made an attempt to update Chart.js to version 2

Source updates are rather limited
Tests are adapted and added some more for other cases
Demo's are adapted to match the same look and feel of version 1.0.x. For the Line chart demo I also added the dynamic update of data as shown in the Chart.js samples

In case of bugs, suggestions, ... let me know

Kind regards, Joris

carlcraig commented 8 years ago

Thanks for putting this PR together :+1:

I will take a look through everything and hopefully get it merged in the next few days.

joris-lambrechts commented 8 years ago

I noticed that the doughnut example page is missing the JavaScript (it says TODO). I'm currently facing problems with pushing the commit for this to github

carlcraig commented 8 years ago

I am going to branch the existing master into a 1.x branch, will then merge this into master.

Everything looks ok for me to merge, we can work on the examples/docs after?

Is there anything else you want to add to this PR?

joris-lambrechts commented 8 years ago

No, I think it is sufficient.

carlcraig commented 8 years ago

Thanks for this contribution :+1:

I have published new v2.0.0 https://github.com/carlcraig/tc-angular-chartjs/releases/tag/v2.0.0 and also on npm.

There is also now a 1.0 branch for the old Chart.js 1 module

joris-lambrechts commented 8 years ago

You're welcome! :)