Contribute integration to Home Assistant

carleeno / elevenlabs_tts

Custom TTS Integration using ElevenLabs API

Apache License 2.0

93 stars 12 forks source link

Contribute integration to Home Assistant #93

Open balloob opened 9 months ago

balloob commented 9 months ago

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

I would love for Home Assistant users to be able to access the high quality voices from Eleven Labs in Home Assistant without having to learn how to install a custom integration.

Describe the solution you'd like

Contribute the integration to Home Assistant core.

Describe alternatives you've considered

Hacs

Additional context

Tag me when you make the PR and mention this issue and I’ll prioritize review.

carleeno commented 9 months ago

Thanks for the request! I'd love to add this as an official integration, however currently I'm traveling full time and unable to dedicate time for developing this much further than keeping the lights on. There is still a lot of missing test coverage which I think will block this becoming part of core for a while.

If you can suggest anybody who'd like to take this over I'd likely be willing to give the keys over to someone with more time for this, or I could at least still support in general maintenance etc. Otherwise I expect at least another couple of months before I settle down and start using HA again (after getting a new home) and would have time and practicality to work on this again.

sorgfresser commented 6 months ago

Hi! I'm not sure whether it would be easy to contribute this to the core repo as core requires any communication with an external service to be done through a pypi-package, thus I'm pretty sure the elevenlabs.py would not go through. I have rewritten part of the integration from scratch using the elevenlabs python sdk and created a PR for this (https://github.com/home-assistant/core/pull/115645) It is not feature complete, so maybe we can take your config_flow.py and add the required features using the elevenlabs python sdk? I did not want to copy your code without asking though...

carleeno commented 6 months ago

Hi! I'm not sure whether it would be easy to contribute this to the core repo as core requires any communication with an external service to be done through a pypi-package, thus I'm pretty sure the elevenlabs.py would not go through. I have rewritten part of the integration from scratch using the elevenlabs python sdk and created a PR for this (home-assistant/core#115645) It is not feature complete, so maybe we can take your config_flow.py and add the required features using the elevenlabs python sdk? I did not want to copy your code without asking though...

@sorgfresser thanks for asking, but it's no problem at all, copy anything that's useful. Maybe when I am able to use HA again I'll be able to start contributing to your official integration rather than this one.