carlescliment / calendar-bundle

A bundle for managing calendars in Symfony 2
40 stars 16 forks source link

French translations #12

Closed DougHayward closed 9 years ago

carlescliment commented 9 years ago

Thanks for the contribution Doug, just one consideration:

Instead of commenting the line with bladetester_calendar.label.event.delete in all the files, could you just get rid of it? It will help to keep the translation files clean.

Thanks!

DougHayward commented 9 years ago

Will do, only reason I hadn't is in-case you didn't want to use the change for any reason. Will sort it in a moment.

DougHayward commented 9 years ago

Except for the rota thing I've suggested is there any improvements you were considering? Maybe ajax/js for adding events

I think That events which span multiple days/hours should stretch on the calendar across the days.

carlescliment commented 9 years ago

Thanks Doug,

about the improvements, my intention was not to create a fit-for-all calendar, but to provide a basic platform and extension points so that anyone could easily develop his/her own features.

Anyway, the feature you mention about spanning events across days sounds interesting and I think it should be part of the core. If you are interested in taking care of it, don't hesitate to start developing it in your own fork. I'll glady review it and send you my feedback. That would be a contribution I'd appreciate very much.

And thanks for the french translations!

DougHayward commented 9 years ago

I'll have a look at implementing it over the next few days back to work now till Tue so a bit time limited.

If you'd rather I did the rota bit seperate I'll create it with a dependency on your bundle then if people want to use both they can. I think much of the ground work is already in place with the calendar bundle so adding it on top shouldn't be much to deal with (hopefully).

Did you get a chance to look at my mock up image?

carlescliment commented 9 years ago

Yep, I'll send you a follow-up tonight. Thanks for sharing your ideas.