Closed njzjz closed 2 years ago
Hi @njzjz. I triggered test execution for your PR but seems we are running into some issues. I do not see that to be directly related with your change but we need to check that. Can you take a look at python2.7 checks.
If we cannot resolve that issue I think we think about dropping python 2.7 support.
It should be related to my change - context manager support is added in Python 3.2 per documentation, i.e. this method. Is it ok to drop python 2.7 support?
Hi, context manager contract in subprocess module you mean. Let's gather feedback on dropping python 2.7 support from the author of the project.
@carletes do you have an opinion on dropping python2.7 support?
@njzjz I guess try, finally replacement could work for now as well if you need quicker merge.
@carletes do you have an opinion on dropping python2.7 support?
Let's drop Python 2.7 support --- about time :)
I'm working on dropping Python 2.7 support now.
@carletes do you have an opinion on dropping python2.7 support?
Let's drop Python 2.7 support --- about time :)
:rocket:
@njzjz: I just dropped Python 2.7 support in branch master
. If you rebase your branch off it, your tests should pass now, I suppose.
I've merged my branch from master.
Great. All checks are fine. We are good to go.
This commit closes
Popen
after itsend_exit_status
. Otherwise, the standard stream will be unclosed, and it may hang when callinghandle_client
again.