search

carletes / mock-ssh-server

Python mock SSH server for testing purposes
MIT License
56 stars 32 forks source link

Mark tests that fail on windows #33

Closed Spitfire1900 closed 1 year ago

Spitfire1900 commented 1 year ago

This is a lightweight way to show what is expected to work on Windows and what does not today. It is unclear right now which tests fail because of mock-ssh-server's implementation and which ones fail because of paramiko itself.

Two changes in scope:

  1. Mark all tests that are known to fail on windows
  2. Copy the implementation of test_ssh_session to test_ssh_exec_command since Windows can open an ssh session but cannot run the exec_command method.
Spitfire1900 commented 1 year ago

tox.ini has been updated to de-select tests that are known to fail on windows only when running windows tests.

Spitfire1900 commented 1 year ago

@carletes any objections to me merging this? Planning on doing so if I don't here back by evening Monday.

carletes commented 1 year ago

Go ahead and merge, @Spitfire1900 --- and thanks for this!