search

carlganz / rintrojs

Wrapper for the Intro.js library
http://rintrojs.carlganz.com/
GNU Affero General Public License v3.0
133 stars 11 forks source link

Not able to switch to elements in different tabs #56

Open ecoisilva opened 2 years ago

ecoisilva commented 2 years ago

Hi,

First of all, thank you for the package, it has been very useful! I made an app using the golem framework, using rintrojs to give a tutorial of the app that switched between multiple tabs (tabs were set with shinydashboard tabItems()). I have created a minimum reproducible example of my app here: https://github.com/ecoisilva/shinyapps.

The tutorial as it is currently set works fine with rintrojs version 0.3.0 (commit c425100537bf6450c8bd8436bbdb055a490c791e), but not with the latest 0.3.2 version. Just switching between these versions is enough to break the tutorial when it switches from tab 1 (Home) to tab 2 (Data). It doesn't show any error when I run it, it simply remains in tab 1 for all the rintrojs boxes.

Let me know if this is sufficient, or if you need more information. Thank you, Inês

carlganz commented 2 years ago

Thanks I was able to reproduce. This is the result of a fix from #38 essentially Shiny Tab Panels and ShinyDashboard tabs have different naming schemes so the fix for one broke the other. Some JavaScript trickery should be able to fix this let me take a look.

carlganz commented 2 years ago

I've determined this is issue with shinydashboard not creating metadata for tabs consistently with shiny. Please upvote my PR to shinydashboard here