carlhuda / janus

Vim distribution
7.88k stars 816 forks source link

Active fork? #290

Closed radicaled closed 12 years ago

radicaled commented 12 years ago

Is anybody maintaining an active fork of Janus?

I see 67 pull requests and 146 still open issues, so I'm assuming that this fork is on hiatus?

telamon commented 12 years ago

Impatience is brewing up.. so what do we do about it? I too would like an collected active fork since there is quite some activity in this project.

kalbasit commented 12 years ago

Yes! I do, check Vimius

Vimius is based on the Experimental branch of Janus with many enhancements and much more plugins, check the wiki which is still a work in progress but Vimius itself is ready..

Pull requests are appreciated.

More on why Vimius was born:

At first I was maintaining a fork (you probably want to check my_pulls branch but keep in mind that it won't receive any support, Vimius however will). 19 of these 67 pull requests are from my fork, but since it took more than 10 minutes for each patch to be re-based on the Experimental branch of Janus, and none of the pull requests were being pulled. I contacted both @carllerche and @wycats and asked then for push access but I got no reply so I decided to stop wasting my time on it and just start my own project.

telamon commented 12 years ago

OK! Fetched your branch, gonna inspect it and merge it once i get home from work. Thank you for your efforts =)

kalbasit commented 12 years ago

@telamon nice kvbd plugin, I included it in Vimius :)

kalbasit commented 12 years ago

@telamon you do have push access to this fork ?

telamon commented 12 years ago

@eMxyzptlk Nope don't have push access. Oh you found my kvbd changes? Great! I had forgotten the name of that plugin.

telamon commented 12 years ago

@eMxyzptlk I just realized that due to the original janus/.gitignore hell the actual KWBD plugin is left uncomitted and ignored, You can find it here https://github.com/rgarver/Kwbd.vim, I have quite an array of other uncategorized things in my folders that never got into the repository; So tonight i'm gonna migrate to vimius since i noticed you sovled that problem with git-submodules. Nice work!

kalbasit commented 12 years ago

@telamon Actually the credits for the submodules idea goes to @wycats Vimius is based on the experimental branch of Janus, of course the entire code has been re-written but still kudos to @wycats

I'll check both yours and @rgarver version, but in the meantime would you mind forking @rgarver's KWBD repository and make your changes there? submodules are better than manual installation I got going...

radicaled commented 12 years ago

@eMxyzptlk thanks, this is exactly what I was looking for.

amaltson commented 12 years ago

I love Janus, +1 for an active fork or the maintainers to get back into it when they have a chance.

wycats commented 12 years ago

fwiw, the reason that Janus has become somewhat inactive is that I have personally switched to the experimental branch, a smaller, (and therefore) more stable distribution that uses pathogen. I have been wary about pulling it into master as it seems a large number of people still use this...

kalbasit commented 12 years ago

@wycats Why not merge my pull requests (the one tagged with [Experimental]) then ? They target the experimental branch.. Anyway I built Vimius on top of the experimental branch and I am also building a gem to completely manage it (adding plugins, enabling/disabling plugins etc..) I'm planning to release it next week, I'm still working on the CLI, the internal is already working..

Check this file it might interest you if you ever want to start working on it again, the interesting function is vimius#add_mapping() which can be used like this:

if has("gui_macvim")
  call vimius#add_mapping('command-t', 'map', '<D-t>', ':CommandT<CR>')
  call vimius#add_mapping('command-t', 'imap', '<D-t>', '<ESC>:CommandT<CR>')

  call vimius#add_mapping('command-t', 'map', '<D-A-t>', ':CommandTFlush<CR>')
  call vimius#add_mapping('command-t', 'imap', '<D-A-t>', '<ESC>:CommandTFlush<CR>')
else
  call vimius#add_mapping('command-t', 'map', '<C-t>', ':CommandT<CR>')
  call vimius#add_mapping('command-t', 'imap', '<C-t>', '<ESC>:CommandT<CR>')

  call vimius#add_mapping('command-t', 'map', '<C-A-t>', ':CommandTFlush<CR>')
  call vimius#add_mapping('command-t', 'imap', '<C-A-t>', '<ESC>:CommandTFlush<CR>')
endif

call vimius#add_mapping('command-t', 'map', '<A-t>', ':CommandTBuffer<CR>')
call vimius#add_mapping('command-t', 'imap', '<A-t>', '<ESC>:CommandTBuffer<CR>')

which adds mappings for command-t and if for some reason the plugin is disabled (for example Vim not built with ruby support)

" Plugins that requires ruby support
if !has("ruby")
  call vimius#disable_plugin("command-t", "Vim is compiled without ruby support")
endif

If the user hits <D-t he won't get an error about ruby support but a message will appear in the commandline telling the user that command-t is disabled because Ruby is not enabled..

amaltson commented 12 years ago

Thanks for the update @wycats. I'll give the experimental branch a whirl. Thanks again for Janus.

wycats commented 12 years ago

@eMxyzptlk I just pulled :)

wycats commented 12 years ago

@eMxyzptlk I'd be happy to give you commit access if you wanted to work on Janus. I perused vimius and the features you added look quite interesting.

kalbasit commented 12 years ago

@wycats I actually requested commit access from you before I forked Vimius, so yea I am still interested.. My vimius gem would then be released to manage Janus...

kalbasit commented 12 years ago

@wycats I'll contact you via private message...

kalbasit commented 12 years ago

I just merged Vimius into the experimental branch, I will try to keep the master branch maintained, but the experimental branch will be the one I'll be focusing on, eventually we will merge experimental into master but not before Vimius the gem is released..