search

carlhuda / janus

Vim distribution
7.88k stars 814 forks source link

Invalid ruby.vim syntax #663

Open leeeeeee opened 8 years ago

leeeeeee commented 8 years ago

I'm using the latest Janus in Zsh 5.2 on Mac OS (El Capitan). However, whenever I open a ruby file, new or old, I get the following warnings:

screen shot 2016-06-29 at 11 14 54 am

I had to take a screenshot because the warnings flashed before the file loaded and weren't scrollable in the terminal window. Janus is usable otherwise (as far as I can tell), but the warning message is rather annoying.

cweilemann commented 8 years ago

+1

kalbasit commented 8 years ago

I just pushed 933f5d043bdc8105f329d3733a5e8d677895a122 please run rake to update Janus, does it solve this problem?

cweilemann commented 8 years ago

I actually got it working late last night by installing the homebrew version of vim... I'm guessing that it's likely because the OS X version of vim is lagging behind. The homebrew version of vim no longer has this problem.

I've uninstalled the homebrew version of vim, ran rake, and tried opening vim again and got the same error. 

$ vim --version
VIM - Vi IMproved 7.3 (2010 Aug 15, compiled Apr  5 2016 14:53:37)

But with homebrew:

VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jun 30 2016 15:56:05)

It works.

leeeeeee commented 8 years ago

For reference, I've had this issue happen even when I was using the brew vim -- and I checked, it's VIM 7.4.

But anyway, I updated Janus, and as long as I actually invoke vim directly, I avoid the warning -- but if enter vi some_file.rb, then I get the warning, so I suppose at this point it's more of a local issue. Looks good now, thanks!

EDIT: And I've confirmed it -- when I vi a file and run :ve, it shows that it's version 7.3! Whereas vim's :ve reports 7.4.

alvincrespo commented 8 years ago

@cweilemann Thanks for the note there. That helped me out.